Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix templates deployer to avoid writing #157

Merged
merged 4 commits into from Sep 5, 2019

Conversation

@facuspagnuolo
Copy link
Member

commented Sep 4, 2019

No description provided.

@facuspagnuolo facuspagnuolo requested review from izqui and sohkai Sep 4, 2019

@facuspagnuolo facuspagnuolo self-assigned this Sep 4, 2019

@izqui izqui referenced this pull request Sep 4, 2019
21 of 22 tasks complete

@facuspagnuolo facuspagnuolo force-pushed the staging_deploy branch from 576becd to e1290d7 Sep 4, 2019

@facuspagnuolo facuspagnuolo force-pushed the staging_deploy branch 2 times, most recently from 2e28234 to 9fc1f9f Sep 4, 2019

templates/reputation/arapp.json Outdated Show resolved Hide resolved
@facuspagnuolo

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

True, this is being done by the templates deployer, I think I carried this error since the refactor. Will turn this PR into a fix for that then

@facuspagnuolo facuspagnuolo force-pushed the staging_deploy branch from 9fc1f9f to 5c7ad80 Sep 5, 2019

@facuspagnuolo facuspagnuolo changed the title Chore: Staging deploy Chore: Fix templates deployer to avoid writing Sep 5, 2019

@facuspagnuolo facuspagnuolo force-pushed the staging_deploy branch 2 times, most recently from c0f5307 to 8487075 Sep 5, 2019

@sohkai
sohkai approved these changes Sep 5, 2019
Copy link
Member

left a comment

👍

@facuspagnuolo facuspagnuolo force-pushed the staging_deploy branch from 8487075 to 2bd6f73 Sep 5, 2019

@facuspagnuolo facuspagnuolo merged commit 28344bc into master Sep 5, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP Ready for review
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the staging_deploy branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.