Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: GovernQueue.veto enhancement #212

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Core: GovernQueue.veto enhancement #212

merged 5 commits into from
Nov 9, 2020

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 9, 2020

closes #12

(This branch is required to finish the test in PR #111)

@nivida nivida added P1 🔜 'We need to do this ASAP' issues T0: Core 🌞 Core issues S1: Feature 👨‍🎨 Adding new stuff labels Nov 9, 2020
@nivida nivida added this to the v1.0: Mainnet launch milestone Nov 9, 2020
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nivida nivida requested a review from izqui November 9, 2020 10:54
Evalir
Evalir approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's remember to re-deploy all infra when this is done, as this introduces contract changes! @bpierre @promaty

packages/govern-core/contracts/pipelines/GovernQueue.sol Outdated Show resolved Hide resolved
packages/govern-core/contracts/pipelines/GovernQueue.sol Outdated Show resolved Hide resolved
packages/govern-core/contracts/pipelines/GovernQueue.sol Show resolved Hide resolved
@nivida nivida merged commit e8977c4 into core-protocol-changes Nov 9, 2020
@nivida nivida deleted the enhancement/veto-with-challenged-state branch November 9, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@izqui izqui Awaiting requested review from izqui

Assignees
No one assigned
Labels
P1 🔜 'We need to do this ASAP' issues S1: Feature 👨‍🎨 Adding new stuff T0: Core 🌞 Core issues
Projects
None yet
Milestone
v1.0: Mainnet launch
Development

Successfully merging this pull request may close these issues.
3 participants
@nivida @CLAassistant @Evalir