Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aragonAPI docs restructure #127

Merged
merged 10 commits into from Apr 4, 2019

Conversation

4 participants
@0xGabi
Copy link
Member

0xGabi commented Mar 30, 2019

closes #102

TODO:

@0xGabi 0xGabi requested a review from 0x6431346e Mar 30, 2019

@0xGabi 0xGabi added this to In progress in Aragon Mesh Team via automation Mar 31, 2019

@0xGabi 0xGabi moved this from In progress to Review in Aragon Mesh Team Mar 31, 2019

@sohkai sohkai requested a review from 2color Apr 2, 2019

Show resolved Hide resolved docs/api-intro.md Outdated
Show resolved Hide resolved docs/api-intro.md Outdated

sohkai and others added some commits Apr 2, 2019

Apply suggestions from code review
Co-Authored-By: 0xGabi <gabrielpk.18@gmail.com>
Show resolved Hide resolved docs/api-intro.md Outdated
Show resolved Hide resolved docs/api-intro.md Outdated
Show resolved Hide resolved docs/api-intro.md Outdated
@2color

2color approved these changes Apr 3, 2019

Copy link
Contributor

2color left a comment

Nice! Besides a couple of small suggestions, this is moving in the right direction.

2color and others added some commits Apr 3, 2019

Apply suggestions from code review
Co-Authored-By: 0xGabi <gabrielpk.18@gmail.com>
@@ -29,9 +29,9 @@ Some of the things you can do with the JavaScript implementation are:

#### Docs

- [React API](js-ref-react.md)

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 3, 2019

Member

I'd probably move this as a subcategory of the App API


- Connect contracts to front-end
- Interact with the EVM and [aragonOS](os-intro.md) when using the full Aragon System
- Interact with contracts directly – an abstraction over web3.js

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 3, 2019

Member

I'd combine these two lines into one:

- Interact with aragonOS and aragonOS-powered applications directly through an abstraction over web3.js
- Interact with the EVM and [aragonOS](os-intro.md) when using the full Aragon System
- Interact with contracts directly – an abstraction over web3.js
- Get access to application state with built in client-side caching
- Pull [Radspec](human-readable-txs.md) notices from contracts

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 3, 2019

Member
Suggested change
- Pull [Radspec](human-readable-txs.md) notices from contracts
- Create human-readable transaction descriptions for your smart contracts through [Radspec](human-readable-txs.md)

delfipolito and others added some commits Apr 3, 2019

@0xGabi 0xGabi merged commit 18f2b53 into aragon:master Apr 4, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

Aragon Mesh Team automation moved this from Review to Done Apr 4, 2019

@0xGabi 0xGabi referenced this pull request Apr 4, 2019

Merged

Add api-quick-start #129

@0xGabi 0xGabi deleted the 0xGabi:feat/aragonAPI-restructure branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.