Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyling of docs texts and titles #133

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@delfipolito
Copy link
Contributor

delfipolito commented Apr 10, 2019

No description provided.

@delfipolito delfipolito requested review from sohkai, 0xGabi and luisivan Apr 10, 2019

@0xGabi

0xGabi approved these changes Apr 11, 2019

Copy link
Member

0xGabi left a comment

This looks much better with the changes!

@0xGabi

This comment has been minimized.

Copy link
Member

0xGabi commented Apr 11, 2019

Also, I have a couple of style suggestion:

  1. I notice bullet points have no space from margin. I think the style for bullet points in this page is more clear.
  2. I review other projects using Docusaurus and I like the side bar on this one. They use a scroll option for the sidebar.

@delfi what you think? We can discuss about them and open a new PR if make sense.

@delfipolito

This comment has been minimized.

Copy link
Contributor Author

delfipolito commented Apr 12, 2019

Good catch on the bullet points @0xGabi ! I added the same margin as the paragraphs 👍.
As for the sidebar, is a good option! We can discuss it with Adri and open another PR if its necessary :)

@sohkai

sohkai approved these changes Apr 12, 2019

Copy link
Member

sohkai left a comment

The sections are so much more clear now!

@delfipolito delfipolito merged commit 0c8f481 into aragon:master Apr 15, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.