Skip to content

Commit

Permalink
fix(js-client): exclude dist from tsconfig.json (#20)
Browse files Browse the repository at this point in the history
* fix(js-client): exclude dist from tsconfig.json

not excluding dist would result in an error trying to run tests after
the client has been built

* ci(js-client): fix missing env in build
  • Loading branch information
mathewmeconry committed Nov 15, 2023
1 parent a4a768b commit da4da85
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/js-client-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ jobs:
- name: Build JS Client
run: yarn run build
working-directory: packages/js-client
env:
INFURA_API_KEY: ${{ secrets.INFURA_API_KEY }}

- name: Integration test
run: yarn test integration --ci --coverage --passWithNoTests >> $GITHUB_STEP_SUMMARY
Expand Down
3 changes: 2 additions & 1 deletion packages/js-client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,6 @@
"resolveJsonModule": true,
// TODO remove once generics are implemented in ContextCore
"useDefineForClassFields": false
}
},
"exclude": ["./dist/"]
}

0 comments on commit da4da85

Please sign in to comment.