Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Ping Web3 libraries to version 1.0.0-beta.34 #21

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented Apr 15, 2019

Pinging web3 libraries to avoid NPM from installing latest beta versions which do not follow the interface we are using.

@sohkai

sohkai approved these changes Apr 15, 2019

Copy link
Member

left a comment

Yes... particularly web3-eth-abi had a weird and small breaking API change :(.

@izqui

izqui approved these changes Apr 16, 2019

Copy link
Member

left a comment

Had to do this yesterday in #7 (30bdd9f) as well so I could deploy the server

@sohkai sohkai merged commit 31cf21f into master Apr 16, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the ping_web3_versions branch Apr 16, 2019

@facuspagnuolo facuspagnuolo self-assigned this Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.