Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize PPF contract functions #27

Merged
merged 2 commits into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@facuspagnuolo
Copy link
Contributor

commented Jul 2, 2019

A little bit of polishing following some rules we already agreed on other repos

@facuspagnuolo facuspagnuolo requested a review from sohkai Jul 2, 2019

@facuspagnuolo facuspagnuolo self-assigned this Jul 2, 2019

@sohkai

sohkai approved these changes Jul 3, 2019

@@ -0,0 +1,69 @@
0 silly input [ 'test' ]

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 3, 2019

Member

Can we remove this file 😄?

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Jul 3, 2019

Author Contributor

🤦‍♂ my bad

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Jul 3, 2019

Author Contributor

🤦‍♂ my bad

* @param quote Address for the quote token the base is denominated in
* @return XRT for base:quote and the timestamp when it was updated
*/
function get(address base, address quote) public view returns (uint128, uint64) {

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 3, 2019

Member

Generally we put view functions after non-view functions.

We normally have a linting rule set up for this; I'm surprised we haven't set up linting for ppf at all 😅. Could we add a similar ethlint config for these contracts?

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Jul 3, 2019

Author Contributor

sure, let's do that :)

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Jul 3, 2019

Author Contributor

actually this one is an external function, we are overriding its visibility :/

@facuspagnuolo facuspagnuolo merged commit 19d2fb0 into master Jul 3, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Ready for review
Details

@facuspagnuolo facuspagnuolo deleted the ppf_organize_functions branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.