Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using native truffle compiler #46

Closed
sohkai opened this Issue Apr 1, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@sohkai
Copy link

sohkai commented Apr 1, 2019

Idea

We should use the native solc binaries to compile our contracts when we deploy them, as the JS-tooling stack is fairly insecure. We should make sure all tests pass after this native compilation.

Technical requirements

Investigate if we need to switch completely to truffle@5 or if we can stay on truffle@4 for now (to avoid too much immediate work).

@facuspagnuolo

This comment has been minimized.

Copy link

facuspagnuolo commented Apr 1, 2019

I think Truffle 5 supports a native solidity version to compile (see here) and a dockerized one. They introduced multiple alternatives actually.

@izqui

This comment has been minimized.

Copy link
Member

izqui commented Apr 1, 2019

AFAIK, the main issue with the truffle 5 upgrade (see breaking changes) is that we'd need to rewrite all the JS code (tests and scripts) to use web3.js 1.0. Unless we can avoid doing this migration (or we can automate it), this could end up being a huge undertaking for just one sprint.

Also given that apps are compiled and deployed by the CLI, we'd also need to upgrade the CLI to truffle 5.

@facuspagnuolo

This comment has been minimized.

Copy link

facuspagnuolo commented Apr 3, 2019

I gave it a try in the SVRP project that I've already migrated to Truffle 5 in it worked fine. It implied changing just two lines of code, after migrating all the tests ofc haha (see here). I you guys think it's worth it I can take care of it and start migrating the test suites to Truffle 5.

Additionally, it took half time compiling the contracts with the binaries.

@luisivan luisivan added this to the Sprint 9 milestone Apr 5, 2019

@luisivan luisivan modified the milestone: Sprint 9 Apr 12, 2019

@luisivan luisivan closed this Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.