Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Investigate using native truffle compiler #46
We should use the native solc binaries to compile our contracts when we deploy them, as the JS-tooling stack is fairly insecure. We should make sure all tests pass after this native compilation.
Investigate if we need to switch completely to
AFAIK, the main issue with the truffle 5 upgrade (see breaking changes) is that we'd need to rewrite all the JS code (tests and scripts) to use web3.js 1.0. Unless we can avoid doing this migration (or we can automate it), this could end up being a huge undertaking for just one sprint.
Also given that apps are compiled and deployed by the CLI, we'd also need to upgrade the CLI to truffle 5.
I gave it a try in the SVRP project that I've already migrated to Truffle 5 in it worked fine. It implied changing just two lines of code, after migrating all the tests ofc haha (see here). I you guys think it's worth it I can take care of it and start migrating the test suites to Truffle 5.
Additionally, it took half time compiling the contracts with the binaries.