Hi Aram, can you help us? #14

Closed
dospuntocero opened this Issue Sep 15, 2012 · 13 comments

Comments

Projects
None yet
5 participants

Hi aram, im working in a module similar to this one, but for ss3, probably you can be interested in helping us making the module as extendable as this one. I tried my best but i believe some better coding hands are required to achieve a module as good as this one. our repo is:
https://github.com/dospuntocero/DOArticles

thanks pal.

Owner

arambalakjian commented Sep 17, 2012

Hi mate,

I'd love to help, but at the moment I just don't have any spare time, even to spend on DO as Pages module. I am planning to update it to SS3 at some point, so perhaps when I do it can provide some help with your module :)

Aram

Hi Aram,
what parts of your module nedd to be ported to SS3?
The new dataquery, the gridfield and the search?

Owner

arambalakjian commented Sep 17, 2012

It should just be the Data Query and the search, it doesn't use DOM/CTF in the module. The search might just have to be dropped though, as it's a complex hacky solution that has had many iterations. Probably best just to recommend users use one of the other Search Modules like Lucene.

In which case it's just the Data Query, but it's a little more dofficult because of the way the query is bing constructed is not compatible with the new syntax, so it needs a bit of tweaking in the logic too.

Aram

I have see that the main login of Dataobject-as-pages (excluding search) is in this 2 pages:

https://github.com/arambalakjian/DataObjects-as-Pages/blob/master/code/Pages/DataObjectAsPageHolder.php
https://github.com/arambalakjian/DataObjects-as-Pages/blob/master/code/DataObjects/DataObjectAsPage.php

We could take this and make become 2 Decorator (one for controller Page and one for model)

Owner

arambalakjian commented Sep 17, 2012

I can't remember the exact reason that I didn't use decorators, but there was a good one, probably related to the versioning, so I am not sure it would work.

Happy for you to have a look and see if you think it would though.

i try do give a look better

2012/9/17 Aram Balakjian notifications@github.com

I can't remember the exact reason that I didn't use decorators, but there
was a good one, probably related to the versioning, so I am not sure it
would work.

Happy for you to have a look and see if you think it would though.


Reply to this email directly or view it on GitHubhttps://github.com/arambalakjian/DataObjects-as-Pages/issues/14#issuecomment-8609091.

Yeah good stuff guys, I am keen to aid in the porting of this over to SS3.0 too. Very useful functionality.

Hi, any news on DataObjects-as-Pages SS3.0 porting ?

Owner

arambalakjian commented Oct 25, 2012

Unfortunately not so far, still not using SS3 on any production sites. As soon as we do this will happen, but they need to fix some of the more annoying bugs first ;)

no problem aram. thanks for your answer.

Owner

arambalakjian commented Nov 8, 2012

This is now done. Please make sure to test extensively before pushing to a production site, I haven't had much time to do proper testing.

2.4 Branch also created for anyone wanting the old code.

Cheers,

Aram

Amazing news Aram, i will start testing it now!

Owner

arambalakjian commented Nov 8, 2012

Awesome! Just commited a couple of little fixes so make sure to use the latest one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment