Feature/extract plugins

[hubert]

hi kannan. here's what i wrote to resolve #152.

i've implemented hipchat with an eye on extracting the skype notification stuff next. this is working and it illustrates my approach to being able to configure the base job with plugins.

this seemed a good point for us to collaborate and figure out a next step together.

[arangamani]

@hubert Perfect. I'll take a look over the weekend.

[arangamani]

@hubert Everything looks good. Have you thought about integrating plugins that work with resources other than jobs?

[hubert]

@arangamani burning the midnight oil i see :-) happy to hear it looks good to you.

i'm actually not that familiar with jenkins. my current company uses it but this is my first real exposure to it. i'll need to read up on other types of plugins to see how they work, but perhaps that can be a next step.

regarding, this particular pull request. how would you like to proceed? i see these as the primary options.

• we could add a section to the readme for the new approach to plugins and then merge so it could go out for the next release. leave skype as is for now for backwards compatibility but not that these options would be moved to a plugin in the next non-patch release.
• do the above but instead extract the skype related stuff.
• make the job configurable via the current manner or the new plugin style. in this case, we'd need to decide how to handle the case where a skype plugin was provided and skype settings were passed.

[hubert]

hi @arangamani. wanted to check in to see if you had further thoughts. i've got some other features that i need to implement that i'd love to see make their way back into the mainline repo, so let me know how you think would be the right way to proceed.

[arangamani]

Let's do the first bullet you mentioned above and merge it in. We can handle the other cases with backward compatibility in mind later.

[hubert]

great. i've update the pull request to include the details about plugins in the readme.

i've also got the workspace cleanup plugin (that i reference in the readme) teed up that i'll PR once this gets merged.

[arangamani]

👍

[arangamani]

@hubert This is released as part of v1.1.0. Could you introduce this feature by making a post to jenkins_api_client@googlegroups.com?

[hubert]

Sure. I'll do this tomorrow.

-h

On Wednesday, November 5, 2014, Kannan Manickam notifications@github.com
wrote:

@hubert https://github.com/hubert This is released as part of v1.1.0.
Could you introduce this feature by making a post to
jenkins_api_client@googlegroups.com
javascript:_e(%7B%7D,'cvml','jenkins_api_client@googlegroups.com');?

—
Reply to this email directly or view it on GitHub
#153 (comment)
.

[hubert]

hi kannan. a little bit of a delay because work craziness, but it's up now!

-h

On Wed, Nov 5, 2014 at 12:58 AM, hubert hubert77@gmail.com wrote:

Sure. I'll do this tomorrow.

-h

On Wednesday, November 5, 2014, Kannan Manickam notifications@github.com
wrote:

@hubert https://github.com/hubert This is released as part of v1.1.0.
Could you introduce this feature by making a post to
jenkins_api_client@googlegroups.com?

—
Reply to this email directly or view it on GitHub
#153 (comment)
.

[arangamani]

@hubert Perfect, no problem at all!