Simple Request methods #27

Closed
moonglum opened this Issue Nov 9, 2012 · 4 comments

Comments

Projects
None yet
1 participant
@moonglum
Contributor

moonglum commented Nov 9, 2012

While I refactored the Query Class (af72aeb) some interesting helper methods emerged:

  • allowed_options
  • prepare_request_data
  • simple_query_request
  • put_request
  • post_request

They are all defined as private methods on Query. But they all belong in the Connection class. They will be moved there. This requires almost no afford on the implementation side. But it needs some rearranging of specs. get_request and delete_request should be added, too. Then other classes can benefit from this change, too.

@ghost ghost assigned moonglum Nov 9, 2012

@moonglum

This comment has been minimized.

Show comment Hide comment
@moonglum

moonglum Nov 9, 2012

Contributor

The more I think about it, the more I suspect they belong to the Database class. They need to know about the Cursor Class, and the Connection should not know about that.

Contributor

moonglum commented Nov 9, 2012

The more I think about it, the more I suspect they belong to the Database class. They need to know about the Cursor Class, and the Connection should not know about that.

@moonglum

This comment has been minimized.

Show comment Hide comment
@moonglum

moonglum Nov 9, 2012

Contributor

...and simple_query_request belongs to the Collection class.

Contributor

moonglum commented Nov 9, 2012

...and simple_query_request belongs to the Collection class.

@moonglum

This comment has been minimized.

Show comment Hide comment
@moonglum

moonglum Nov 16, 2012

Contributor

I played around with this. But I'm not sure yet. I don't want to include it in the next release.

Contributor

moonglum commented Nov 16, 2012

I played around with this. But I'm not sure yet. I don't want to include it in the next release.

@moonglum

This comment has been minimized.

Show comment Hide comment
@moonglum

moonglum May 24, 2013

Contributor

Refactored.

Contributor

moonglum commented May 24, 2013

Refactored.

@moonglum moonglum closed this May 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment