-
Notifications
You must be signed in to change notification settings - Fork 72
GT-60 OPS CLI with Arango Task #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // | ||
| // DISCLAIMER | ||
| // | ||
| // Copyright 2016-2022 ArangoDB GmbH, Cologne, Germany | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
| // | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| goflag "flag" | ||
|
|
||
| "github.com/spf13/cobra" | ||
| flag "github.com/spf13/pflag" | ||
| ) | ||
|
|
||
| var ( | ||
| cmdOps = cobra.Command{ | ||
| Use: "arangodb_ops", | ||
| Run: executeUsage, | ||
| } | ||
| ) | ||
|
|
||
| func ExecuteOps() int { | ||
| flag.CommandLine.AddGoFlagSet(goflag.CommandLine) | ||
|
|
||
| if err := cmdOps.Execute(); err != nil { | ||
| return 1 | ||
| } | ||
|
|
||
| return 0 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // | ||
| // DISCLAIMER | ||
| // | ||
| // Copyright 2016-2022 ArangoDB GmbH, Cologne, Germany | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
| // | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "os" | ||
|
|
||
| "github.com/arangodb/kube-arangodb/cmd" | ||
| ) | ||
|
|
||
| func main() { | ||
| os.Exit(cmd.ExecuteOps()) | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // | ||
| // DISCLAIMER | ||
| // | ||
| // Copyright 2016-2022 ArangoDB GmbH, Cologne, Germany | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
| // | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "github.com/rs/zerolog/log" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func init() { | ||
| var deploymentName string | ||
|
|
||
| cmdMain.AddCommand(cmdTask) | ||
| cmdOps.AddCommand(cmdTask) | ||
|
|
||
| cmdTask.AddCommand(cmdTaskCreate) | ||
| cmdTaskCreate.Flags().StringVarP(&deploymentName, ArgDeploymentName, "d", "", | ||
| "Name of ArangoDeployment for which Task will be created - necessary when more than one deployment exist within one namespace") | ||
|
|
||
| cmdTask.AddCommand(cmdTaskState) | ||
| } | ||
|
|
||
| var cmdTask = &cobra.Command{ | ||
| Use: "task", | ||
| Run: executeUsage, | ||
| } | ||
|
|
||
| var cmdTaskCreate = &cobra.Command{ | ||
| Use: "create", | ||
| Short: "Create task", | ||
| Run: taskCreate, | ||
| } | ||
|
|
||
| var cmdTaskState = &cobra.Command{ | ||
| Use: "state", | ||
| Short: "Get Task state", | ||
| Long: "It prints the task current state on the stdout", | ||
| Run: taskState, | ||
| } | ||
|
|
||
| func taskCreate(cmd *cobra.Command, args []string) { | ||
| log.Info().Msgf("TODO: create task") | ||
| } | ||
|
|
||
| func taskState(cmd *cobra.Command, args []string) { | ||
| log.Info().Msgf("TODO: check task state") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both binaries are expected to have the same build params, it is possible to slightly simplify the code using
$(foreachExample in arangosync: https://github.com/arangodb/arangosync/blob/feature/arangosync-migration/Makefile#L157
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to implement this more refactor in the project files structure is required since the paths are different (i can not place all main files under the same paths due to the linter requirements)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwierzbo I'm just worried we have another new binary is planned to be added and it would multiply the duplication even more. But I think it can be refactored in a separate PR 👍