Skip to content

Conversation

@ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 18, 2018

This PR replaced the custom events.Create with a more standard record.EventRecord to create events.
The benefit of this is that this enables event compression: When multiple events of the same type&reason are created in succession, the count is increased instead of created more and more events.

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 97a46a6 into master Jun 18, 2018
@ewoutp ewoutp deleted the bugfix/correlate-events branch June 18, 2018 14:36
@ewoutp ewoutp removed the 4 - Review label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants