-
Notifications
You must be signed in to change notification settings - Fork 72
Dashboard for ArangoLocalStorage operator #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
44cec70
95643d3
14ba8c5
f5caa22
6a2dba8
2710416
415563d
8bdea37
55d2bb6
60dd852
995975f
eaa1f19
581f316
8369d6e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,4 @@ docs | |
| pkg | ||
| tools | ||
| deps | ||
|
|
||
| dashboard | ||
Large diffs are not rendered by default.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,23 @@ | ||
| import React, { Component } from 'react'; | ||
| import logo from './logo.svg'; | ||
| import './App.css'; | ||
| import { Message } from 'semantic-ui-react'; | ||
| import { Container, Message, Modal, Segment } from 'semantic-ui-react'; | ||
|
|
||
| class NoOperator extends Component { | ||
| render() { | ||
| return ( | ||
| <div className="App"> | ||
| <header className="App-header"> | ||
| <img src={logo} className="App-logo" alt="logo" /> | ||
| <h1 className="App-title">Welcome to Kube-ArangoDB</h1> | ||
| </header> | ||
| <p className="App-intro"> | ||
| There are no operators available yet. | ||
| </p> | ||
| {this.props.podInfoView} | ||
| {(this.props.error) ? <Message error content={this.props.error}/> : null} | ||
| </div> | ||
| <Container> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This Minor nitpick: no point in using a class component here, you could just make it a function. |
||
| <Modal open> | ||
| <Modal.Header>Welcome to Kube-ArangoDB</Modal.Header> | ||
| <Modal.Content> | ||
| <Segment basic> | ||
| <Message color="orange"> | ||
| There are no operators available yet. | ||
| </Message> | ||
| </Segment> | ||
| {this.props.podInfoView} | ||
| {(this.props.error) ? <Message error content={this.props.error}/> : null} | ||
| </Modal.Content> | ||
| </Modal> | ||
| </Container> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import React, { Component } from 'react'; | ||
| import { Button, Container, Form, Icon, Message, Modal } from 'semantic-ui-react'; | ||
| import { css } from 'react-emotion'; | ||
|
|
||
| const LoginView = ({username, password, onUsernameChanged, onPasswordChanged, doLogin, error}) => ( | ||
| <Container> | ||
|
|
@@ -12,6 +13,7 @@ const LoginView = ({username, password, onUsernameChanged, onPasswordChanged, do | |
| <label>Password</label> | ||
| <input type="password" value={password} onChange={(e) => onPasswordChanged(e.target.value)}/> | ||
| </Form.Field> | ||
| <Form.Button className={css`display:none`} type="submit" /> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any particular reason you have a hidden submit button here? Pressing enter in the input field should already trigger the form submit. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also curious why you're using
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hidden button was out of need. I expected it to work without, but it did not.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like |
||
| </Form> | ||
| {(error) ? <Message error content={error}/> : null} | ||
| </Container> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this is why HOCs have been losing some traction to render props recently: you're now injecting props from two places. This is probably fine for the time being but it can get a bit confusing as the complexity grows.