Skip to content

Conversation

@ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Aug 21, 2018

This PR prevents overriding critical arangod & arangosync arguments by validating the args list of the server groups.

@ghost ghost assigned ewoutp Aug 21, 2018
@ghost ghost added the 2 - Working label Aug 21, 2018
@ewoutp ewoutp requested review from kvahed and neunhoef August 27, 2018 12:24
Copy link
Contributor

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 23b0283 into master Aug 30, 2018
@ewoutp ewoutp deleted the bugfix/reject-critical-args branch August 30, 2018 10:00
@ghost ghost removed the 4 - Review label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants