Skip to content

Conversation

@maierlars
Copy link
Contributor

@maierlars maierlars commented Jan 10, 2019

Add the exporter as side car for the arangod process.

fixes #257

@maierlars maierlars self-assigned this Jan 10, 2019
@maierlars maierlars requested review from ewoutp and neunhoef January 10, 2019 09:03
@ghost ghost added the 2 - Working label Jan 10, 2019
@maierlars maierlars force-pushed the feature/arangodbexporter branch from 20924cf to 7ece108 Compare March 20, 2019 14:33
@maierlars maierlars mentioned this pull request May 2, 2019
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Prometheus stuff.

}

// IsPodFailed returns true if all containers of the pod
// have terminated and at least one of them wih a non-zero exit code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust comment.

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit 1932867 into master May 3, 2019
@neunhoef neunhoef deleted the feature/arangodbexporter branch May 3, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate arangodb-exporter

4 participants