-
Notifications
You must be signed in to change notification settings - Fork 72
ArangoExporter support #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20924cf to
7ece108
Compare
neunhoef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Prometheus stuff.
pkg/util/k8sutil/pods.go
Outdated
| } | ||
|
|
||
| // IsPodFailed returns true if all containers of the pod | ||
| // have terminated and at least one of them wih a non-zero exit code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust comment.
neunhoef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add the exporter as side car for the arangod process.
fixes #257