Skip to content

Conversation

@maierlars
Copy link
Contributor

No description provided.

@maierlars maierlars self-assigned this Feb 7, 2019
@maierlars maierlars requested a review from neunhoef February 7, 2019 10:02
@ghost ghost added the 2 - Working label Feb 7, 2019
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several questions & suggestions

MemberPhaseFailed MemberPhase = "Failed"
// MemberPhaseCleanOut indicates that a dbserver is in the process of being cleaned out
MemberPhaseCleanOut MemberPhase = "CleanOut"
// MemberPhaseDrain indicates that a dbserver is n the process of being cleaned out as result of draining a node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n -> in

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit 32ac512 into master Feb 18, 2019
@neunhoef neunhoef deleted the bug-fix/drain-node-cleanout branch February 18, 2019 10:12
@ghost ghost removed the 2 - Working label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants