No Coords #339
Merged
No Coords #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is in strange phase but there is no plan, fail it.
ghost
added
the
ewoutp
suggested changes
Feb 12, 2019
| allMembersReady := status.Members.AllMembersReady(spec.GetMode(), spec.Sync.IsEnabled()) | ||
| status.Conditions.Update(api.ConditionTypeReady, allMembersReady, "", "") | ||
|
|
||
| if status.Members.Coordinators.AllFailed() { |
Contributor
There was a problem hiding this comment.
This expression seems to "soon".
Shouldn't it given the coordinators some time first?
Contributor
Author
There was a problem hiding this comment.
If they are failed, the operator will create a member replacement plan anyways. However, if all are failed, the execution of the plan will always fail because it can not connect to the cluster. So no, if all coordinators are failed, there is nothing we can do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete all coordinator pods if all coordinators are failed. If a pod is in strange phase but there is no plan, view it as failed.