Skip to content

Conversation

@neunhoef
Copy link
Member

No description provided.

@ghost ghost assigned neunhoef Feb 21, 2019
@ghost ghost added the 2 - Working label Feb 21, 2019
@ghost ghost assigned sleto-it Feb 21, 2019
@sleto-it sleto-it self-requested a review February 21, 2019 15:21
Copy link
Contributor

@sleto-it sleto-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with https://github.com/arangodb/planning/issues/3668 in mind . While we continue to work to integrate this into the official manual, we will do a new round of review (especially simran will check again also my commits, etc)

@ghost ghost assigned Simran-B Feb 21, 2019
Copy link
Contributor

@Simran-B Simran-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written overall. We might want to restructure such articles a bit in future, to separate clearer between the different parts (technical backgrounds, guides, check lists).

@sleto-it
Copy link
Contributor

all the open conversation will be considered for a future pr

@sleto-it sleto-it merged commit 1720f41 into master Feb 21, 2019
@ghost ghost removed the 2 - Working label Feb 21, 2019
Copy link
Contributor

@lservini lservini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maierlars maierlars deleted the bug-fix/add-drain-documentation branch March 4, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants