bug-fix/bad-remove-member #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
neunhoef
requested changes
Feb 25, 2019
Member
neunhoef
left a comment
neunhoef
left a comment
There was a problem hiding this comment.
LGTM, but 2 occurrences of dead code, please remove. I now do a manual test and approve then.
| return false, maskAny(errors.Wrapf(err, "Failed to remove server from cluster: %#v", err)) | ||
| } else if driver.IsPreconditionFailed(err) { | ||
|
|
||
| //if !m.Conditions.IsTrue(api.ConditionTypeTerminated) { |
Member
There was a problem hiding this comment.
We should probably remove this dead code.
| } | ||
| a.log.Warn().Msg("dbserver is failed but still in use") | ||
| } | ||
| //} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.