Skip to content

Check variables before codegen. #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

Check variables before codegen. #391

merged 1 commit into from
Jun 5, 2019

Conversation

@joerg84
Copy link
Contributor

@joerg84 joerg84 commented Jun 3, 2019

As the codegen is rather expensive it makes sense to check the variables before.

@joerg84 joerg84 requested a review from neunhoef June 3, 2019 16:50
@joerg84 joerg84 requested a review from maierlars June 4, 2019 13:11
maierlars
maierlars approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maierlars maierlars merged commit b9f99c8 into master Jun 5, 2019
@maierlars maierlars deleted the makefile branch June 5, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neunhoef neunhoef Awaiting requested review from neunhoef

1 more reviewer

@maierlars maierlars maierlars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joerg84 @maierlars