ArangoDB version in membership status #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maierlars
suggested changes
Jul 24, 2019
Contributor
maierlars
left a comment
maierlars
left a comment
There was a problem hiding this comment.
Does not work. Member Status Version is set to current version without look for the actual version running in the pod
joerg84
reviewed
Jul 24, 2019
joerg84
reviewed
Jul 24, 2019
maierlars
suggested changes
Jul 25, 2019
neunhoef
approved these changes
Jul 25, 2019
Member
neunhoef
left a comment
neunhoef
left a comment
There was a problem hiding this comment.
LGTM. We go without a test, since this is a very simple change.
Contributor
Tests are still useful to prevent regressions and enable refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.