Upgrade/golang1.13 #469
Merged
Upgrade/golang1.13 #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test which checks if version has been changed Remove unnecessary variables from Makefile remove commit change
informalict
force-pushed
the
upgrade/golang1.13
branch
from
a7e79df to
dc6682c
Compare
maierlars
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that pull request, I did preparation to upgrade "Go" to the newer version. I dockerized our build.
For the time being we can not upgrade golang to 1.13 because of prometheus-operator package. There is a change in Prometheus operator in master and once it will be merged then we can change golang version to 1.13.