Skip to content

[Bugfix] skip rotation when number of containers is not the same #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[Bugfix] skip rotation when number of containers is not the same #793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/deployment/rotation/arangod_containers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ func containersCompare(_ api.DeploymentSpec, _ api.ServerGroup, spec, status *co
return func(builder api.ActionBuilder) (mode Mode, plan api.Plan, err error) {
a, b := spec.Containers, status.Containers

if len(a) == 0 || len(b) == 0 {
if len(a) == 0 || len(a) != len(b) {
// If the number of the containers is different or is zero then skip rotation.
return SkippedRotation, nil, nil
}

Expand Down