Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Changed APPIRATER_APP_ID #define to static NSString #26

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

frankus commented Jul 1, 2011

I tried replacing the integer app ID with a code snippet (we have like 40 different targets and are pulling the app ID out of a configuration file), and found that the code was expecting a bare integer. So I deleted the -stringWithFormat: call, and changed the #define to the @"12355" format.

I can see arguments both ways, but this parallels the other #defines (some of which are code snippets) a bit better.

Thanks for this project, by the way. It's well-written and a real time-saver!

Changed #define APPIRATER_APP_ID to static NSString
This means that you can replace the definition with a snippet of code (say, pulling it from a configuration file for different targets). The previous code only worked with a bare integer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment