Skip to content

externalize properties #51

Open
wants to merge 9 commits into from

2 participants

@ypelud
ypelud commented Jul 18, 2012

Hy,

first many thanks for your work.

I adapt your project to externalize the properties in a file Appriter.plist. If the file does not exist the "old" define s are using.

Yann

@hisham
hisham commented Aug 30, 2012

Is this pull request ever going to be merged with master? This seems like a popular request, many pull requests addressing the same issue of making app id configurable outside of Appirater.h. Would be great to have this functionality in the master branch.

@ypelud ypelud Merge remote-tracking branch 'upstream/master'
Conflicts:
	da.lproj/Appirater.strings
	da.lproj/AppiraterLocalizable.strings
	da.lproj/Localizable.strings
	de.lproj/Appirater.strings
	de.lproj/AppiraterLocalizable.strings
	de.lproj/Localizable.strings
	en.lproj/Appirater.strings
	en.lproj/AppiraterLocalizable.strings
	en.lproj/Localizable.strings
	es.lproj/Appirater.strings
	es.lproj/AppiraterLocalizable.strings
	es.lproj/Localizable.strings
	fr.lproj/Appirater.strings
	fr.lproj/AppiraterLocalizable.strings
	fr.lproj/Localizable.strings
	it.lproj/Appirater.strings
	it.lproj/AppiraterLocalizable.strings
	it.lproj/Localizable.strings
	ja.lproj/Appirater.strings
	ja.lproj/AppiraterLocalizable.strings
	ja.lproj/Localizable.strings
	ko.lproj/Appirater.strings
	ko.lproj/AppiraterLocalizable.strings
	ko.lproj/Localizable.strings
	nl.lproj/Appirater.strings
	nl.lproj/AppiraterLocalizable.strings
	nl.lproj/Localizable.strings
	pl.lproj/Appirater.strings
	pl.lproj/AppiraterLocalizable.strings
	pl.lproj/Localizable.strings
	pt.lproj/Appirater.strings
	pt.lproj/AppiraterLocalizable.strings
	pt.lproj/Localizable.strings
	ru.lproj/Appirater.strings
	ru.lproj/AppiraterLocalizable.strings
	ru.lproj/Localizable.strings
	sv.lproj/Appirater.strings
	sv.lproj/AppiraterLocalizable.strings
	sv.lproj/Localizable.strings
dce356e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.