Latest version of node.js (v0.10.0) breaks coffee-toaster #64

Closed
zslayton opened this Issue Mar 18, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@zslayton

The same coffee.toaster file has been working in node v.0.8.17. I upgraded today and found that trying to run either 'toaster -w' or 'toaster -c' would cause the following:

bash-3.2$ toaster -w

path.js:313
throw new TypeError('Arguments to path.resolve must be strings');
^
TypeError: Arguments to path.resolve must be strings
at Object.exports.resolve (path.js:313:15)
at Toast.__t.Toast.Toast.toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:104:23)
at Toast.toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:27:61)
at Toast.eval (eval at Toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:90:16), :2:6)
at new Toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:90:11)
at new Toaster (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:1354:22)
at Object.exports.run (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:1296:12)
at Object. (/usr/local/lib/node_modules/coffee-toaster/bin/toaster:7:27)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)

@arboleya

This comment has been minimized.

Show comment Hide comment
@arboleya

arboleya Mar 20, 2013

Owner

I'll take a look.

Owner

arboleya commented Mar 20, 2013

I'll take a look.

@geowarin

This comment has been minimized.

Show comment Hide comment
@geowarin

geowarin Mar 21, 2013

I ran into the same error with a freshly installed toaster.
I think error is not in node, but rather is a misplaced parenthesis in lib/toaster.js at line 104.

It reads :
else if (path.resolve(srcpath !== srcpath))
when it should probably be :
else if (path.resolve(srcpath) !== srcpath)

I ran into the same error with a freshly installed toaster.
I think error is not in node, but rather is a misplaced parenthesis in lib/toaster.js at line 104.

It reads :
else if (path.resolve(srcpath !== srcpath))
when it should probably be :
else if (path.resolve(srcpath) !== srcpath)

@arboleya

This comment has been minimized.

Show comment Hide comment
@arboleya

arboleya Mar 26, 2013

Owner

@geowarin You're right, I'm releasing a patch for each soon.

Owner

arboleya commented Mar 26, 2013

@geowarin You're right, I'm releasing a patch for each soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment