Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-96948 Make category facet available #752

Closed
wants to merge 249 commits into from
Closed

Conversation

@thektan
Copy link

thektan commented Jun 17, 2019

http://issues.liferay.com/browse/LPS-96948

The issue was that the imported init.jsp contains (SearchDisplayContext)request.getAttribute(WebKeys.PORTLET_DISPLAY_CONTEXT) which class type changes for each portlet.

I think a better fix might be to move the entire SearchDisplayContext searchDisplayContext = (SearchDisplayContext)request.getAttribute(WebKeys.PORTLET_DISPLAY_CONTEXT); out of init.jsp and place it only in files that need it and keep init.jsp as a universal import, but I'm not sure if that would impact performance. Plus it might introduce more regressions so I thought the current fix in this PR was more appropriate as it follows the pattern of other facet portlets too.

liferay-translation and others added 30 commits Jun 15, 2019
This reverts commit 70ba670.
ruben-pulido and others added 16 commits Jun 17, 2019
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jun 17, 2019

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@thektan

This comment has been minimized.

Copy link
Author

thektan commented Jun 17, 2019

ci:test:search

@thektan

This comment has been minimized.

Copy link
Author

thektan commented Jun 17, 2019

ci:test:sf

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jun 17, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 19 seconds 792 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 42c201804c15236985712a8a43675e7ceb738e88

Sender Branch:

Branch Name: pr-53
Branch GIT ID: 1c593096ad2b35ad1c4ddc4860f619632470603b

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jun 18, 2019

ci:test:search - 16 out of 21 jobs passed in 1 hour 27 minutes 22 seconds 152 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 981daf11884a6c5ea7f18b08b82e0a9ef4ff397f

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 5e2a3af288c0eee5f221f7d2c9b259f3343ccb24

16 out of 21 jobs PASSED
16 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at 3494cee:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    1397 Tests Passed.
    5 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #307183
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=20102, accountId=20104, webId=liferay.com, key=tLnOyOOmWtl2ydf4OIr8ug==, mx=liferay.com, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        java.lang.NullPointerException
        	at com.liferay.oauth2.provider.scope.internal.liferay.ScopeLocatorImpl.getScopeAliases(ScopeLocatorImpl.java:233)
        	at com.liferay.fragment.internal.instance.lifecycle.OAuth2ProviderShortcutPortalInstanceLifecycleListener.portalInstanceRegistered(OAuth2ProviderShortcutPortalInstanceLifecycleListener.java:78)
        	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.registerCompany(PortalInstanceLifecycleListenerManagerImpl.java:171)
        	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.addPortalInstanceLifecycleListener(PortalInstanceLifecycleListenerManagerImpl.java:103)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
        	at org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
        	at org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
        	at org.apache.felix.s...
    2. AXIS_VARIABLE=2,label_exp=!master #307183
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=20102, accountId=20104, webId=liferay.com, key=moTW6+Z/RV/GZG0AR67q6A==, mx=liferay.com, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        java.lang.NullPointerException
        	at com.liferay.oauth2.provider.scope.internal.liferay.ScopeLocatorImpl.getScopeAliases(ScopeLocatorImpl.java:233)
        	at com.liferay.fragment.internal.instance.lifecycle.OAuth2ProviderShortcutPortalInstanceLifecycleListener.portalInstanceRegistered(OAuth2ProviderShortcutPortalInstanceLifecycleListener.java:78)
        	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.registerCompany(PortalInstanceLifecycleListenerManagerImpl.java:171)
        	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.addPortalInstanceLifecycleListener(PortalInstanceLifecycleListenerManagerImpl.java:103)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
        	at org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
        	at org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
        	at org.apache.felix.s...
    3. AXIS_VARIABLE=3,label_exp=!master #307183
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=20102, accountId=20104, webId=liferay.com, key=P/97Nn5iFmGofW0ii7NpqQ==, mx=liferay.com, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        java.lang.NullPointerException
        	at com.liferay.oauth2.provider.scope.internal.liferay.ScopeLocatorImpl.getScopeAliases(ScopeLocatorImpl.java:233)
        	at com.liferay.fragment.internal.instance.lifecycle.OAuth2ProviderShortcutPortalInstanceLifecycleListener.portalInstanceRegistered(OAuth2ProviderShortcutPortalInstanceLifecycleListener.java:78)
        	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.registerCompany(PortalInstanceLifecycleListenerManagerImpl.java:171)
        	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.addPortalInstanceLifecycleListener(PortalInstanceLifecycleListenerManagerImpl.java:103)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
        	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
        	at org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
        	at org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
        	at org.apache.felix.s...
    4. ...
@joshchong

This comment has been minimized.

Copy link

joshchong commented Jun 20, 2019

ci:close

Bug is no longer reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.