LPS-112603 portal-search-elasticsearch7-impl:add http port from ElasticsearchConfiguration instead of the default one. #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LPS-111624 is fixed
With `npx yarn-deduplicate yarn.lock`.
The goal of this change is to mark the `Liferay.Util.disableEsc` function as deprecated. This function is used in a few places: In the `archived` directory, which we don't want to update, but don't want to break either https://github.com/liferay/liferay-portal/blob/1991cde6e2f3ef10689a7b32c819cd91cf9faa55/modules/apps/archived/flash-web/src/main/resources/META-INF/resources/configuration.jsp#L61 https://github.com/liferay/liferay-portal/blob/1991cde6e2f3ef10689a7b32c819cd91cf9faa55/modules/apps/archived/web-proxy-web/src/main/resources/META-INF/resources/configuration.jsp#L56 And in current modules that are still "active" https://github.com/liferay/liferay-portal/blob/aba1c8126c487579a96eeddd977f1f1ecd91ae3b/modules/apps/iframe/iframe-web/src/main/resources/META-INF/resources/configuration.jsp#L144 https://github.com/liferay/liferay-portal/blob/3750e154e3b73509e0cda8c5f77ebb47a099b4de/portal-web/docroot/html/taglib/ui/input_field/page.jsp#L520 https://github.com/liferay/liferay-portal/blob/3750e154e3b73509e0cda8c5f77ebb47a099b4de/portal-web/docroot/html/taglib/ui/input_field/page.jsp#L529 For now, marking this function as deprecated seems like the safest option, in the future if we wan't to disable the "escape" key, it might be worth relying on something else than `window.event.returnValue`, as it doesn't seem to be supported in Firefox as mentioned here https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue
As discussed here wincent#235 (comment) strict equality (`===`) will be enforced soon by our linter so we don't want to use "loose equality" (`==`) for new files
… the minifier
Apparently there is nothing wrong but there seems to be some problem with the minifier that is confusing itself with some expressions, babel transforms the String Literal to `goog.module("".concat(variant, "Adapter.incrementaldom"));`.
…ldren making impossible to drag something inside the collection items
…ime. Removing role alert when the banner gets focus so screen readers are reading again and again with every update
Based on: wincent#231 I think there were a few of problems with that approach: - Missing "]" at end of selectors. - `blur()` would explode, because as soon as we remove the `[role="alert"]`, the `A.one()` call has nothing to find, will return `null` and we die calling `.setAttribute()` on `null`. So, this commit makes a few changes: - If we always pass `counterTextNode` into `_uiSetRemainingTime()`, we don't need to re-find the node inside that method. - Rather than finding `[role="alert"]` anywhere in the document, scope the search more tightly by using `.closest()` and starting from the counter. - Store the found alert in `this._alert` so that we can find it later on when restoring the `[role="alert"]`. The remaining problem: I am not sure whether `blur()` is the right place to restore the role. For example, if I have focus on the alert close button, and I tab to the "Extend" button, `blur()` will fire because the close button lost focus, and that bubbles (apparently; that seems non-standard to me, but maybe it is an AUI thing, because that's what I'm seeing when I test this). As a result, `[role="alert"]` gets added back and then removed again after 1 second. Notes on YUI and "blur" bubbling: - https://yuilibrary.com/yui/docs/event/focus.html (they fake it). - https://developer.mozilla.org/en-US/docs/Web/API/Element/blur_event (it is not supposed to bubble). So one final change, I make sure we only blur when the focus really leaves the entire notification, using `contains()` and `relatedTarget`. Still need to confirm that that is right: for example, when the alert shows, we remove `[role="alert"]` after one second; if you then tab out of the alert, we add back the `[role="alert"]`, and one second later, it gets removed again.
As described here: antonio-ortega#113 (comment) > I tested in VoiceOver. When you tab away from the alert, you do indeed > hear the alert again after one second (but only once). I think the > right behavior, then, might be to *not* re-add the role on `blur`, > but rather, on *next* `focus`; ie. only when re-focusing, and with > the same `relatedTarget` check to make sure that fake event bubbling > doesn't destroy everything. So, this commit moves the code from `blur` to `focus`. Re-testing shows that it gives the desired result, at least with VoiceOver. Reads out the alert text when the alert first appears; doesn't re-read it just because you tab around inside the alert; but does re-read it exactly once when you tab back into the alert from the outside.
…ssetListEntrySegmentsEntryRel
…r value to avoid 3rd party pop-up/modal/maximize solution to interfere
ElasticsearchConfiguration instead of the default one. https://issues.liferay.com/browse/LPS-112603
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ElasticsearchConnectionFixture to point to test location https://issues.liferay.com/browse/LPS-112603
|
Merged to dev branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.