Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-catalogue is gone #1975

Merged
merged 12 commits into from
Sep 20, 2022

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Sep 9, 2022

This is prep for meson in addition to simplifying (ie reducing) the amount of scripting
we have. In the long run, I'd like to remove BuildModules.cmake too, but this might
be superseded by meson and this PR is self-contained.

Changes

  • modcc accepts now a list of NMODL files
  • likewise, modcc is now able to spit out a catalogue.cpp file
  • remove the generate-catalogue script, simplify a-b-c
  • remove some options from modcc we never use
  • No longer allow external modcc

TODO

  • Re-enable raw CXX files when building catalogues.

@thorstenhater thorstenhater marked this pull request as ready for review September 13, 2022 08:24
@brenthuisman
Copy link
Contributor

TODO looks done, correct?

@thorstenhater
Copy link
Contributor Author

Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think doc/dev/extending_catalogues.rst can use an update. Looks like it never mentioned this script (only in a comment).

@thorstenhater
Copy link
Contributor Author

Done, and the overall 'API' is much simpler again

@brenthuisman brenthuisman merged commit 04762cf into arbor-sim:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants