Make decor mandatory and labels optional.

[thorstenhater]

• Make decor mandatory
• ...and label arguments to cable cell optional
• Put the most optional argument (labels) last.

[brenthuisman]

In which cases would a user want a cable cell without decoration?

[thorstenhater]

Well, for one it's used quite often in our tests. Second, we had support for it before.

[brenthuisman]

Tests are perhaps not what defaults should be based on. And I can't imagine a simulation of cells without any mechanisms. So unless there is an actual use case, I would like to require it such that people don't forget that cells without e.g. mechanisms are almost certainly not what they want.

[thorstenhater]

They could have always done that so far, but sure, I see the point. More breaking change then ;)

[thorstenhater]

Done.

[boeschf]

Looks good - these small changes have quite a substantial ripple effect!
Please merge with master, there are a couple of recipes in the SDE tests that need to be updated.

[brenthuisman]

@thorstenhater If you could merge master and address @boeschf 's comments, we can merge these breaking changes before v0.8.

[thorstenhater]

Done, I fixed two new warnings in test_sde along with it.

• sde_recipe& add_probe(probe_tag tag, std::any address) hides a virtual on its base class
• auto sampler_ = [ncells, nsteps] (std::vector<arb_value_type>& results, unsigned count, doesn't use its ncells capture.

[boeschf]

there is one more recipe to fix in test_sde, line 826 (only enabled when compiling for GPU)

[thorstenhater]

Also, there's the malloc_consolidate: invalid chunk size again.

[thorstenhater]

bors try

[bors]

try

Build failed:

• ci/gitlab/gitlab.com

[brenthuisman]

bors try

[brenthuisman]

ci/release/build.Dockerfile contains a hardcoded URL to CMake 3.16 (Bors failed on that line, not the tests this time). Since elsewhere there was a bump, we could do so here too.

[bors]

try

Build failed:

• ci/gitlab/gitlab.com

[thorstenhater]

That file hasn't changed in a while and I have this:

RUN wget -q "https://github.com/Kitware/CMake/releases/download/v3.18.6/cmake-3.18.6-Linux-x86_64.tar.gz" -O cmake.tar.gz && \
    echo "87136646867ed65e935d6bacd44d52a740c448ad0806f6897d8c3d47ce438c8b cmake.tar.gz" | sha256sum --check --quiet && \
    tar --strip-components=1 -xzf cmake.tar.gz -C /usr/local && \
    rm -rf cmake.tar.gz