Introduce indexable getter #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
commented
May 25, 2023
|
@dalg24 I'd like to get a review despite some tests commenting out. Mainly, I want to see what you think about overall approach and whether you see any issues on a high level. |
aprokop
force-pushed
the
legacy_indexable_getter
branch
from
2832179
to
cf24c07
Compare
dalg24
reviewed
May 25, 2023
Open
Co-authored-by: Damien L-G <dalg24@gmail.com>
aprokop
force-pushed
the
legacy_indexable_getter
branch
from
cf24c07
to
ba77769
Compare
dalg24
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is edging us closer towards APIv2. In the new API, we'll store values, and require an indexable getter to produce an indexable that will be used to construct a hierarchy. Indexable getter will eventually be provided by a user.
For now, though, we are using an indexable getter that converts a stored pair of (index, bounding_volume) to bounding_volume.
We still rely on the indexable to be the same type as the bounding volume in this patch.