Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't mark nil ids as dups #33

Closed
wants to merge 1 commit into from
Closed

Conversation

yisraeldov
Copy link
Contributor

Fixes an issue where you can't sync more than one new task #22

@yisraeldov
Copy link
Contributor Author

@arbox @plajjan Any chance to get this merged in ? With out it you can only create one new task at a time.

@plajjan
Copy link
Collaborator

plajjan commented Feb 12, 2018

I've tried and it appears to works correctly. I plan on merging this as part of the gitlab changes.

@yisraeldov indent is using a mix of tabs and spaces in this particular patch. Would be super if you could check your settings so any further patches are aligned with the rest of the file. Thanks for patch (I also ran into this problem when working on the gitlab patch) :)

@yisraeldov
Copy link
Contributor Author

yisraeldov commented Feb 12, 2018 via email

@plajjan
Copy link
Collaborator

plajjan commented Feb 21, 2018

This change, though not this exact commit, was included in #34, that is now merged, so I'm closing this.

@plajjan plajjan closed this Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants