New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: made color accessible #709
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@CBID2 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi, appreciate you change, but I dont think this color fits our UI desing well. Maybe we can make |
What can we make @dartpain? |
|
Sorry didn't finish, Make some changes with the help of @tenokami |
|
@CBID2 Sorry, I can't find where were the colors changed. Could you please show me? |
|
@CBID2 Thanks, i'm afraid this is too much. It attracts more attention than anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this @tenokami?
|
Made the change @tenokami |
|
Thank you @holopin-bot @CBID2 |
|
Congratulations @CBID2, you just earned a badge! Here it is: https://holopin.io/claim/cloecbm6z217740fl753zouoa7 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |


What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
In this PR, I make the the background color accessible based on the following advice from the Accessible Insights website:
Fix the following:
Element has insufficient color contrast of 3.94 (foreground color: #808080, background color: #ffffff, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1Element has insufficient color contrast of 3.94 (foreground color: #808080, background color: #ffffff, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1
Use foreground color: #727272 and the original background color: #ffffff to meet a contrast ratio of 4.81:1.
Why was this change needed? (You can also link to an open issue here)
This change would make it easier for users with low-vision to view the site.
Closes 🐛 Bug Report: Site needs more accessible colors #701
Other information:
I would like to count this PR towards Hacktoberfest