Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made color accessible #709

Merged
merged 2 commits into from Oct 31, 2023
Merged

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 26, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    In this PR, I make the the background color accessible based on the following advice from the Accessible Insights website:
    Fix the following:

  • Element has insufficient color contrast of 3.94 (foreground color: #808080, background color: #ffffff, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1Element has insufficient color contrast of 3.94 (foreground color: #808080, background color: #ffffff, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1

  • Use foreground color: #727272 and the original background color: #ffffff to meet a contrast ratio of 4.81:1.

  • Why was this change needed? (You can also link to an open issue here)
    This change would make it easier for users with low-vision to view the site.
    Closes 🐛 Bug Report: Site needs more accessible colors #701

  • Other information:
    I would like to count this PR towards Hacktoberfest

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 5:37pm
nextra-docsgpt ❌ Failed (Inspect) Oct 30, 2023 5:37pm

@vercel
Copy link

vercel bot commented Oct 26, 2023

@CBID2 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@dartpain
Copy link
Contributor

Hi, appreciate you change, but I dont think this color fits our UI desing well. Maybe we can make

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 29, 2023

Hi, appreciate you change, but I dont think this color fits our UI desing well. Maybe we can make

What can we make @dartpain?

@dartpain
Copy link
Contributor

Sorry didn't finish,

Make some changes with the help of @tenokami

@tenokami
Copy link
Collaborator

@CBID2 Sorry, I can't find where were the colors changed. Could you please show me?

@dartpain
Copy link
Contributor

Here:
Screenshot 2023-10-30 at 09 29 13

@tenokami
Copy link
Collaborator

@CBID2 Thanks, i'm afraid this is too much. It attracts more attention than anything else.
Let's go with 595959
image

Copy link
Contributor Author

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this @tenokami?

frontend/src/conversation/Conversation.tsx Outdated Show resolved Hide resolved
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 30, 2023

Made the change @tenokami

@tenokami
Copy link
Collaborator

@CBID2 Thank you!

@dartpain Will review and merge this

@dartpain dartpain merged commit 8289067 into arc53:main Oct 31, 2023
3 of 4 checks passed
@dartpain
Copy link
Contributor

Thank you @holopin-bot @CBID2

@holopin-bot
Copy link

holopin-bot bot commented Oct 31, 2023

Congratulations @CBID2, you just earned a badge! Here it is: https://holopin.io/claim/cloecbm6z217740fl753zouoa7

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@CBID2 CBID2 deleted the making-colors-accessible branch October 31, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Site needs more accessible colors
3 participants