New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reputation_instance_onkill #316

Closed
Magnifikator opened this Issue Nov 26, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@Magnifikator

Magnifikator commented Nov 26, 2012

In the table reputation_instance_onkill are reputation values listed for killing mobs or bosses in instances (or defined maps).

However the value for killing mobs is valid for EVERY mob. Even for rats, snakes, frogs .... with level 1 :-)

I don't think that this is correct.

Suggestion: May we should count that value only for mobs with a level > 5 or 10 ?

@dfighter1985

This comment has been minimized.

Show comment
Hide comment
@dfighter1985

dfighter1985 Nov 26, 2012

Member

No need for that. We can just check if the mob is a critter.

Member

dfighter1985 commented Nov 26, 2012

No need for that. We can just check if the mob is a critter.

@Magnifikator

This comment has been minimized.

Show comment
Hide comment
@Magnifikator

Magnifikator Nov 26, 2012

These 3 npcs I found are indeed marked as critters (8).

But some other level 1 npc are marked as non-combat pet (12) or beast (1). But I dont know if you can find them also in instances.

So please let's filter the critters out.

Magnifikator commented Nov 26, 2012

These 3 npcs I found are indeed marked as critters (8).

But some other level 1 npc are marked as non-combat pet (12) or beast (1). But I dont know if you can find them also in instances.

So please let's filter the critters out.

@dfighter1985

This comment has been minimized.

Show comment
Hide comment
@dfighter1985

dfighter1985 Dec 17, 2012

Member

Beast is probably some npc's pet.
Non-combat pets should not even be killable, so there's no need for exception there.

Member

dfighter1985 commented Dec 17, 2012

Beast is probably some npc's pet.
Non-combat pets should not even be killable, so there's no need for exception there.

Artox pushed a commit to Artox/arcemu that referenced this issue Mar 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment