New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcScripts ... #289

Merged
merged 6 commits into from Oct 14, 2012

Conversation

Projects
None yet
3 participants
@Artox

Artox commented Oct 3, 2012

I reviewed all occurences of sEAS.SpawnCreature. On my way I replaced all GetQuestLogForEntry by HasQuest where appropriate and fixed the one place my new assert could be triggered.

Also I found a place where there was a comment by azolex. I changed the loop to use the same defines as array indices as comparable code in Unit::HasAura does.

Player* p_caster;
for(int i = 0; i < 100; i++) //random number - azolex(should be max aura fields, no idea and dont care)

This comment has been minimized.

@jackpoz

jackpoz Oct 4, 2012

Member

azolex(should be max aura fields, no idea and dont care)

This sums up his whole contribution to the ArcEmu project.

@jackpoz

jackpoz Oct 4, 2012

Member

azolex(should be max aura fields, no idea and dont care)

This sums up his whole contribution to the ArcEmu project.

This comment has been minimized.

@dfighter1985

dfighter1985 Oct 4, 2012

Member

With a little effort he could have made it funny at least :
http://xkcd.com/221/

@dfighter1985

dfighter1985 Oct 4, 2012

Member

With a little effort he could have made it funny at least :
http://xkcd.com/221/

dfighter1985 added a commit that referenced this pull request Oct 14, 2012

@dfighter1985 dfighter1985 merged commit ee0ccfa into arcemu:master Oct 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment