Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added symfony 3.x version + CS fixes #3

Merged
merged 5 commits into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@andreybolonin
Copy link
Contributor

andreybolonin commented Aug 13, 2016

No description provided.

@andrey1s

This comment has been minimized.

Copy link
Contributor

andrey1s commented Aug 13, 2016

also need update factory service, for example Resources/config/reply_message.xml and other

@andreybolonin

This comment has been minimized.

Copy link
Contributor Author

andreybolonin commented Aug 17, 2016

What about minimum 3.x symfony versions?

@@ -31,7 +31,7 @@ public function getName()
return 'clickatell_reply_message';
}
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function setDefaultOptions(OptionsResolver $resolver)

This comment has been minimized.

@andrey1s

andrey1s Aug 17, 2016

Contributor

setDefaultOptions wrong parameter type
symfony 2.8 and 3.0 use configureOptions

@andrey1s

This comment has been minimized.

Copy link
Contributor

andrey1s commented Aug 17, 2016

we can use symfony ~2.8 and ~3.0

andreybolonin added some commits Aug 17, 2016

Merge remote-tracking branch 'origin/master'
# Conflicts:
#	Form/Type/ReplyMessageFormType.php
#	Form/Type/SendMessageFormType.php
@andreybolonin

This comment has been minimized.

Copy link
Contributor Author

andreybolonin commented Aug 17, 2016

Ok

@andrey1s andrey1s merged commit 3e20688 into archer-soft:master Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.