Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label expression $source{type} of a relation is not resolved, while $source{name} works fine #673

Closed
olwol opened this issue Sep 16, 2020 · 3 comments

Comments

@olwol
Copy link

olwol commented Sep 16, 2020

Version of Archi

com.archimatetool.editor.buildid=202007151058
com.archimatetool.editor.versionid=4.7.1

Archi Plug-ins

grafik

Operating System

os.arch=amd64
os.name=Windows 10
os.version=10.0

Expected Behaviour

With the label expression of the aggregation relation shown in the picture
$source{type} "$source{name}"
${name}
$target{type} "$target{name}"
[${type}]

I would expect what is shown in the picture while I see the actual behaviour shown in the picture as well:

grafik

Actual Behaviour

So
$source{type}
$target{type}
is not resolved, while $source{name} and $target{name} works fine.

Steps to Reproduce the Behaviour

Set the label expression of the aggregation relation to:
$source{type} "$source{name}"
${name}
$target{type} "$target{name}"
[${type}]

Is my expectation wrong?

Phillipus added a commit that referenced this issue Sep 16, 2020
* This will need more testing
* See #673
@Phillipus
Copy link
Member

I think your expectation is correct, however the current implementation of ${type} does not support reference prefixes.

However, I've just pushed a speculative fix for this, and with some more testing should be part of the next version of Archi.

@Phillipus
Copy link
Member

Testing your example case with the speculative fix results in this:

Image 1

@olwol
Copy link
Author

olwol commented Sep 17, 2020

Thanks a lot for your quick response. Looking forward for the next version of Archi.
With kind regards, Olav

@olwol olwol closed this as completed Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@Phillipus @olwol and others