Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: html lang attribute always reads "en" (English) #297

Closed
sevein opened this issue Oct 24, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@sevein
Copy link
Contributor

commented Oct 24, 2018

Expected behaviour
The html element should reflect the language of the contents sent to the browser.

Current behaviour
The html element is always rendered as follows regardless the language of the contents:

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">

Steps to reproduce

  1. Open Dashboard
  2. Go to Administration > Language
  3. Choose a lang other than English, e.g. Brazilian Portuguese
  4. Open the source of the page and inspect the html element and its attributes

Your environment (version of Archivematica, OS version, etc)
AM18 qa/1.x a90faa9.


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@sevein

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

Looking at mozilla/bedrock, they have some logic behind their LANG that it's worth checking. See https://github.com/mozilla/bedrock/blob/master/bedrock/base/templates/base-resp.html.

@sallain

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2018

It would be nice to fix this alongside the final i18n things!

@ablwr

This comment has been minimized.

Copy link

commented Feb 4, 2019

Sorry @sevein we are experiencing some Waffle weirdness here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.