Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: can't arrange a SIP from backlog with long names #53

Closed
sevein opened this issue Aug 2, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@sevein
Copy link
Contributor

commented Aug 2, 2018

My transfer looks as the one below. To reproduce, re-create a similar structure. Start the transfer, move it to backlog and then try to arrange a new SIP from it.

University_Suspendisse_and_Legal_Interdum_-_Board_and_Senate_records__2010-2017
└── University_Suspendisse_and_Legal_Interdum
    └── Board_of_Foobars_-_XYZ_Material
        └── Board_of_Foobars_XYZ_-_11_Jun_1999_-_Agenda_-_Pdf.txt

The SIP never appears in the user interface. SS returns a 500 error but the Dashboard doesn't let the user know about the situation. SS throws an error (rsync can't locate files).

The problem seems to be in that the values that we're storing in main_siparrange during the arrangement are stripped by MySQL due to the type used in original_path and arrange_path.

This is the schema of main_siparrange (models.SIPArrange).

 CREATE TABLE `main_siparrange` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `original_path` varchar(255) DEFAULT NULL,
  `arrange_path` varchar(255) NOT NULL,
  `file_uuid` varchar(36) DEFAULT NULL,
  `transfer_uuid` varchar(36) DEFAULT NULL,
  `sip_created` tinyint(1) NOT NULL,
  `aip_created` tinyint(1) NOT NULL,
  `level_of_description` varchar(2014) NOT NULL,
  `sip_id` varchar(36) DEFAULT NULL,
  PRIMARY KEY (`id`),
  UNIQUE KEY `original_path` (`original_path`),
  KEY `main_siparrange_2664b5aa` (`sip_id`),
  CONSTRAINT `main_siparrange_sip_id_601574f35f1ea7ec_fk_SIPs_sipUUID` FOREIGN KEY (`sip_id`) REFERENCES `SIPs` (`sipUUID`)
) ENGINE=InnoDB AUTO_INCREMENT=8 DEFAULT CHARSET=latin1

Version: 1.8-dev

@sevein sevein self-assigned this Aug 2, 2018

qubot pushed a commit to artefactual/archivematica that referenced this issue Aug 2, 2018

Models: use longblob in SIPArrange
Convert `varchar` columns into `longblob`.

This is connected to archivematica/Issues#53.

qubot pushed a commit to artefactual/archivematica that referenced this issue Aug 2, 2018

Models: use longblob in SIPArrange
Convert `varchar` columns into `longblob`.

This is connected to archivematica/Issues#53.

qubot pushed a commit to artefactual/archivematica that referenced this issue Aug 9, 2018

Models: use longblob in SIPArrange
Convert `varchar` columns into `longblob`.

This is connected to archivematica/Issues#53.

@sevein sevein added this to the 1.8.0 milestone Aug 9, 2018

qubot pushed a commit to artefactual/archivematica that referenced this issue Aug 9, 2018

Models: use longblob in SIPArrange
Convert `varchar` columns into `longblob`.

This is connected to archivematica/Issues#53.

qubot pushed a commit to artefactual/archivematica that referenced this issue Aug 9, 2018

Models: use longblob in SIPArrange
Convert `varchar` columns into `longblob`.

This is connected to archivematica/Issues#53.

qubot pushed a commit to artefactual/archivematica that referenced this issue Aug 9, 2018

Models: use longblob in SIPArrange
Convert `varchar` columns into `longblob`.

This is connected to archivematica/Issues#53.

qubot pushed a commit to artefactual/archivematica that referenced this issue Aug 9, 2018

Models: use longblob in SIPArrange
Convert `varchar` columns into `longblob`.

This is connected to archivematica/Issues#53.

@sevein sevein removed their assignment Sep 17, 2018

@peterVG peterVG self-assigned this Oct 3, 2018

@peterVG

This comment has been minimized.

Copy link

commented Oct 3, 2018

I recreated the same directory structure and placed it in a transfer called "long-dir-test-1":

screen shot 2018-10-03 at 11 23 57

I moved the transfer to backlog but when I try to arrange a SIP from it, the directory doesn't open to lower levels like it does for other backlog directories, i.e. it stays uncollapsed when clicking the arrow icon (note: this happens in both Chrome & Firefox)

screen shot 2018-10-03 at 11 52 06

qubot pushed a commit to artefactual/archivematica that referenced this issue Oct 10, 2018

Dashboard: fix glitch with long names
The file browser wasn't handling text overflow properly - the expand
button was being shadowed by the directory name. This commit changes the
layout of directory items so it behaves as a grid where the button and
the text behave as columns within its row.

This connects to archivematica/Issues#53.

qubot pushed a commit to artefactual/archivematica that referenced this issue Oct 10, 2018

Dashboard: fix glitch with long names
The file browser wasn't handling text overflow properly - the expand
button was being shadowed by the directory name. This commit changes the
layout of directory items so it behaves as a grid where the button and
the text behave as columns within its row.

This connects to archivematica/Issues#53.

qubot pushed a commit to artefactual/archivematica that referenced this issue Oct 10, 2018

Dashboard: fix glitch with long names
The file browser wasn't handling text overflow properly - the expand
button was being shadowed by the directory name. This commit changes the
layout of directory items so it behaves as a grid where the button and
the text behave as columns within its row.

This connects to archivematica/Issues#53.

@sevein sevein removed their assignment Oct 10, 2018

@sevein

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2018

Back to you, Peter! The problem you found was a CSS glitch, the button was being hidden by the directory name when it was too long. Fixed in artefactual/archivematica#1288.

@peterVG

This comment has been minimized.

Copy link

commented Oct 10, 2018

Verified fixed on Bionic in Firefox and Chrome:

screen shot 2018-10-10 at 14 21 22

@sromkey sromkey closed this Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.