Added gzip helper to tar module #65

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

jstuckey commented Mar 21, 2014

Added gzip helper option to the tar module as mentioned in ctalkington#36.

Owner

ctalkington commented Mar 22, 2014

thanks for the PR, will review as soon as possible.

@ctalkington ctalkington added a commit that referenced this pull request Mar 23, 2014

@ctalkington ctalkington few adjustments to #65.
* add gzipOptions to control compression
* make pipe logic more general for potential future compression formats.
d95e0c1
Owner

ctalkington commented Mar 23, 2014

manually merged bits of this. really don't like adding deps for the tests and gzip def adds hassle to the test. its such a simple change that we can deal with tests when a better way of testing is setup.

published as 0.7.0, let me know if you have comments / concerns.

Contributor

jstuckey commented Mar 25, 2014

Works for me. Just wanted to contribute.

I agree that the second test is complex. The first test it('should gzip the tar archive', ... might be good to include for code coverage though. It is the same as your other tests in that it just checks the digest. No extra dependancies required.

Owner

ctalkington commented Mar 25, 2014

@jstuckey noted. the test might fail though with the digest because of zlib differences between OS. ran into this in the very beginning of this project.

Owner

ctalkington commented Mar 25, 2014

that said in a future version, the tests will actually un-gzip and try to parse the archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment