Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Dashboard Controller params; resolves #154. #163

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@ruebot
Copy link
Member

commented Aug 21, 2018

GitHub issue(s):

#154

What does this Pull Request do?

This should cover the missing params coverage in the Dashboard Controller test.

How should this be tested?

  • TravisCI turns green
  • CodeCov goes up, and this line is coverage in the report
@codecov

This comment has been minimized.

Copy link

commented Aug 21, 2018

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files          34       34           
  Lines         425      425           
=======================================
  Hits          387      387           
  Misses         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9aabf...a184b4d. Read the comment docs.

@ruebot ruebot force-pushed the ruebot:issue-154 branch from 37ea178 to a184b4d Aug 21, 2018

@ruebot

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2018

Hrm. Looks like I have some more research to do.

@ruebot ruebot added the on hold label Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.