Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI and design #161

Merged
merged 26 commits into from Jan 1, 2021
Merged

Improve UI and design #161

merged 26 commits into from Jan 1, 2021

Conversation

Uzay-G
Copy link
Member

@Uzay-G Uzay-G commented Dec 30, 2020

Dramatic improvements in UI and design of the page:

Sneak peek of the home page:

image

Any reviews / comments on the general changes and improvements are greatly appreciated if you clone the branch and check out the new design.

This PR design can / should be worked on to have an even better UI and feedback is extremely useful.

Todo:

  • - Add form for creation of sub dirs

@Uzay-G
Copy link
Member Author

Uzay-G commented Dec 30, 2020

@srevinsaju if you have time this would be incredibly useful

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #161 (83027fe) into master (3dfb0cc) will increase coverage by 0.95%.
The diff coverage is 91.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   81.22%   82.17%   +0.95%     
==========================================
  Files          27       27              
  Lines        1704     1762      +58     
==========================================
+ Hits         1384     1448      +64     
+ Misses        320      314       -6     
Impacted Files Coverage Δ
archivy/api.py 68.00% <ø> (ø)
archivy/config.py 91.30% <ø> (ø)
conftest.py 89.85% <ø> (ø)
tests/integration/test_api.py 100.00% <ø> (ø)
archivy/models.py 84.12% <40.00%> (+0.53%) ⬆️
archivy/__init__.py 82.22% <80.00%> (-0.28%) ⬇️
archivy/routes.py 92.50% <90.24%> (+0.02%) ⬆️
archivy/data.py 93.38% <100.00%> (+5.88%) ⬆️
archivy/forms.py 100.00% <100.00%> (ø)
tests/functional/test_routes.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f86ac...83027fe. Read the comment docs.

archivy/templates/base.html Outdated Show resolved Hide resolved
archivy/templates/click_web/command_form.html Outdated Show resolved Hide resolved
@srevinsaju
Copy link
Member

Can we get a real tree here:
image

something like
image

@Uzay-G
Copy link
Member Author

Uzay-G commented Dec 30, 2020

Oh yeah that type of design is better, you're right.

@Uzay-G
Copy link
Member Author

Uzay-G commented Dec 30, 2020

@srevinsaju wdyt of this?

image

@srevinsaju
Copy link
Member

Looks Amazing ❤️ !!

@Uzay-G
Copy link
Member Author

Uzay-G commented Dec 31, 2020

Alright I think we can merge this, @srevinsaju all good?

@srevinsaju
Copy link
Member

This is still a draft PR, is work still pending?

@srevinsaju
Copy link
Member

Also, the bookmarklet feature doesnt work, leads to 404

@Uzay-G Uzay-G marked this pull request as ready for review January 1, 2021 11:53
@Uzay-G
Copy link
Member Author

Uzay-G commented Jan 1, 2021

What happens for you with the bookmarklet? If everything is up to date, it should work.

@Uzay-G
Copy link
Member Author

Uzay-G commented Jan 1, 2021

Ok I see what you mean - I fixed it.

@Uzay-G
Copy link
Member Author

Uzay-G commented Jan 1, 2021

Should be good now right?

@Uzay-G
Copy link
Member Author

Uzay-G commented Jan 1, 2021

Alright I'm going to merge this in !

@Uzay-G Uzay-G merged commit 947947e into master Jan 1, 2021
@Uzay-G Uzay-G mentioned this pull request Jan 2, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants