Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add missing requirements.txt file #42

Closed
wants to merge 3 commits into from

Conversation

@jamietanna
Copy link
Contributor

commented Dec 21, 2016

In order to more easily track the required dependencies to get the
project up and running, use a requirements.txt file.

Note: This PR is currently a WIP as it would be good to hear thoughts on the best way to lock down dependencies for pyalpm, sqlite and expac, if possible.

@anthraxx
Copy link
Member

left a comment

thx

.gitignore Outdated
@@ -1,2 +1,5 @@
__pycache__/
app.db

virtualenv
venv

This comment has been minimized.

Copy link
@anthraxx

anthraxx Dec 21, 2016

Member

guess just one of those is needed, i would propose to go with the hidden file ".virtualenv" instead

This comment has been minimized.

Copy link
@jamietanna

jamietanna Dec 23, 2016

Author Contributor

Should be sorted as of latest commits.

scrypt==0.8.0
SQLAlchemy==1.1.4
Werkzeug==0.11.11
WTForms==2.1

This comment has been minimized.

Copy link
@anthraxx

anthraxx Dec 21, 2016

Member
  • please don't use frozen dependency versions, its meant to work with the latest. If not, its a bug.
  • please only use direct first-level dependencies and purge the transitive dependencies like click, MarkupSafe etc...
README.md Outdated
virtualenv venv
. venv/bin/activate
pip install -r requirements.txt
```

This comment has been minimized.

Copy link
@anthraxx

anthraxx Dec 21, 2016

Member

actually this is not a python code block, this should just use the regular un-syntaxed code block

@jamietanna jamietanna force-pushed the jamietanna:requirements-file branch from c023c6c to e810d08 Dec 23, 2016

@anthraxx

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

jamietanna added 2 commits Dec 21, 2016
Add missing requirements.txt file
In order to more easily track the required dependencies to get the
project up and running, use a `requirements.txt` file.

@jamietanna jamietanna force-pushed the jamietanna:requirements-file branch from e810d08 to 242b4e9 Dec 23, 2016

@jamietanna

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2016

Woops, missed that! Should be all there now, @anthraxx.

@anthraxx

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

so all looks fine now and the requests.txt is certainly something we could add, however i'm not yet convinced about the virtualenv instructions as without pyalpm this will simply fail to be used. we need proper instruction for pyalpm... hm...

@jamietanna

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2016

Agreed - is there any way we can get pyalpm distributed on PyPi? That would mean we can pull it in as a dependency more easily.

@anthraxx

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

let me see if i can make that happen, need to discuss that

@anthraxx

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

well I would be willing to accept a temporary entry for https://git.archlinux.org/users/remy/pyalpm.git/snapshot/pyalpm-0.8.tar.xz so that the virtualenv instruction works.
We could replace that URL later with a simple name if its available on pypi by its maintainer (already triggered to do so).

@jamietanna

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2016

Sure, I'll push up a commit that adds the URL to pyalpm, and raise a second, WIP PR that we can track progress to getting pyalpm on PyPi. Sound good?

@anthraxx

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

@jamietanna sure, just add that url for the requests.txt... I don't thin we need a meta-PR, I will notice it when we have pyalpm on pypi and i will definitivly not forget to kick the URL out as i hate it there 😝

Add URL for pyalpm package
Currently the pyalpm package isn't on PyPi, as referenced in #42;
temporarily we will use a direct URL to the package.
@jamietanna

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2016

Your call, @anthraxx :) Think that's ready, unless you can see anything else?

anthraxx added a commit that referenced this pull request Dec 23, 2016
setup: add temporary URL for pyalpm package
Currently the pyalpm package isn't on PyPi, as referenced in #42;
temporarily we will use a direct URL to the package.
@anthraxx

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

applied via CLI, thanks a lot

@anthraxx anthraxx closed this Dec 23, 2016

anthraxx added a commit that referenced this pull request Oct 17, 2017
setup: add temporary URL for pyalpm package
Currently the pyalpm package isn't on PyPi, as referenced in #42;
temporarily we will use a direct URL to the package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.