Print error message if no matching PKGBUILD could be found

[kpcyrd]

It currently looks like this:

(4/4) Warn about old perl modules
From https://github.com/archlinux/svntogit-community
 * branch            packages/phpvirtualbox -> FETCH_HEAD
 * [new branch]      packages/phpvirtualbox -> community/packages/phpvirtualbox
Cloning into 'phpvirtualbox'...
done.
/phpvirtualbox /
�[1m�[34m  ->�[0m�[1m Delete snapshot for phpvirtualbox_270554...�[0m

With this patch it should look like this:

(4/4) Warn about old perl modules
From https://github.com/archlinux/svntogit-community
 * branch            packages/phpvirtualbox -> FETCH_HEAD
 * [new branch]      packages/phpvirtualbox -> community/packages/phpvirtualbox
Cloning into 'phpvirtualbox'...
done.
/phpvirtualbox /
ERROR: Failed to find commit this was built with (PKGBUILD checksum didn't match any commit)
�[1m�[34m  ->�[0m�[1m Delete snapshot for phpvirtualbox_270554...�[0m

[Foxboron]

    if ! bash <<-__END__
[[snip]]
__END__; then
    error "Failed to find commit this was built with (PKGBUILD checksum didn't match any commit)"
fi

Shouldn't this work? Then we'd get the exit 1 properly caught and a proper error message as rest of repro.

[kpcyrd]

I got it to work with braces like this:

    if ! (bash <<-__END__
shopt -s globstar
pacman -S asp --noconfirm --needed
asp checkout $pkgbase
pushd $pkgbase
for rev in \$(git rev-list --all -- repos/); do
    pkgbuild_checksum=\$(git show \$rev:trunk/PKGBUILD | sha256sum -b)
    pkgbuild_checksum=\${pkgbuild_checksum%% *}
    if [ \$pkgbuild_checksum = $pkgbuild_sha256sum ]; then
        git checkout \$rev
        mv ./trunk/* /startdir
        exit 0
    fi
done
exit 1
__END__
); then
      echo "ERROR: Failed to find commit this was built with (PKGBUILD checksum didn't match any commit)" >&2
    fi

at first I assumed this would be different because we don't know which command caused the non-zero exit code, but since we don't set -e inside that bash process exit 1 is probably the only one?

[Foxboron]

An alternative is to capture the exit code and do an "mkinitcpio"-style check?

https://github.com/archlinux/mkinitcpio/blob/master/mkinitcpio#L343-L348

I'm not sure what is the most readable, but I'm a little bit unhappy with the pure echo in the subshell instead of dealing with the bash invocation as a command itself.