Wip/debug #21
Closed
Wip/debug #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausenbusk
reviewed
Mar 14, 2021
eli-schwartz
suggested changes
Mar 14, 2021
|
Last set adds the support to |
Signed-off-by: Morten Linderud <morten@linderud.pw>
Signed-off-by: Morten Linderud <morten@linderud.pw>
Signed-off-by: Morten Linderud <morten@linderud.pw>
We simply remove the -debug prefix if present and ensure we are checking the SVN repository for the PKGBUILD in the actual repository. Signed-off-by: Morten Linderud <morten@linderud.pw>
Signed-off-by: Morten Linderud <morten@linderud.pw>
The gist of this change is to always peak into the DEBUGPKGPOOL and
ensure if a ${pkgbase}-debug exists in the debug repository.
Signed-off-by: Morten Linderud <morten@linderud.pw>
This ensures we do not have the debug repository at hand when looking at the SVN state files. However, there is no good way to figure out if we have a debug package as .BUILDINFO nor .PKGINFO has the information we need. We blindly assume that any package where we look up a *-debug repository is a debug package. Signed-off-by: Morten Linderud <morten@linderud.pw>
Signed-off-by: Morten Linderud <morten@linderud.pw>
Internally this uses db-move, so this should just do the correct thing. Signed-off-by: Morten Linderud <morten@linderud.pw>
We check if there is a globfile match for a debug package when removing the package from the main repository. This also adds a guard to the usual package removal, and removing an unused variable. Signed-off-by: Morten Linderud <morten@linderud.pw>
Signed-off-by: Morten Linderud <morten@linderud.pw>
We check if there is a debug package found in the mirroring debug repository and mark this as `is_debug` if found. This creates the needed symlinks for the package pool. Signed-off-by: Morten Linderud <morten@linderud.pw>
This adds a test case for debug packages. It should be noted that nothing has really been changed to support this. This just check that db-repo-remove can remove a package from a *-debug repository with a -debug suffix. However, nice to have this in case regressions. Signed-off-by: Morten Linderud <morten@linderud.pw>
This allows us to test multiple packages, which is relevant for ftpdir-cleanup later on. Signed-off-by: Morten Linderud <morten@linderud.pw>
This implementation is probably the easiest one and/or cheap. After building a list of all packages in the repositories we filter the lists into two separate working lists. One for normal packages and one for debug packages. The only issue is that we can encounter globs with no matching cleanup lists, like when running ftpdir-cleanup after the debug package changes has been introduced, but before deploying new repositories. We guard against this by ensuring we have found debug packages, and normal packages, before checking the working lists. This introduces some duplicated code but should be fine. Rest of the logic is mirrored between the two package pools. Signed-off-by: Morten Linderud <morten@linderud.pw>
We expand the internal __checkRepoRemovedPackage function with globfile lookups towards DEBUGPKGPOOL and the debug repository. This ensures we should get a hit for the relevant debug packages. Signed-off-by: Morten Linderud <morten@linderud.pw>
|
I have reworked all the commits in this branch so they should be easier to review and cherry-pick. |
allanmcrae
approved these changes
May 9, 2021
allanmcrae
reviewed
Sep 6, 2021
| checkRemovedPackage testing pkg-debuginfo | ||
|
|
||
| echo checkRemovedPackage testing-debug pkg-debuginfo-debug | ||
| checkRemovedPackage testing-debug pkg-debuginfo |
There was a problem hiding this comment.
checkRemovedPackage testing-debug pkg-debuginfo-debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.