Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makechrootpkg: keep {SRC,SRCPKG,PKG,LOG}DEST, MAKEFLAGS & PACKAGER values #4

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@ribbons
Copy link
Contributor

commented Mar 16, 2019

If makechrootpkg is called as non-root, the {SRC,SRCPKG,PKG,LOG}DEST, MAKEFLAGS and PACKAGER environment variables are lost in the call to check_root().

Add these to the passed keepenv list so that they are preserved instead.

makechrootpkg: keep *DEST, MAKEFLAGS & PACKAGER
If makechrootpkg is called as non-root, the {SRC,SRCPKG,PKG,LOG}DEST,
MAKEFLAGS and PACKAGER environment variables are lost in the call to
check_root().

Add these to the passed keepenv list so that they are preserved instead.
@Foxboron

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

Very much the same issue as from 7b09525

LGTM.

@anthraxx

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

LGTM, gonna send it over to the ML for giving people the chance to review over there and apply afterwards

@anthraxx

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@anthraxx anthraxx closed this Mar 25, 2019

@ribbons

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Many thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.