Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makechrootpkg: keep {SRC,SRCPKG,PKG,LOG}DEST, MAKEFLAGS & PACKAGER values #4

Closed
wants to merge 1 commit into from
Closed

makechrootpkg: keep {SRC,SRCPKG,PKG,LOG}DEST, MAKEFLAGS & PACKAGER values #4

wants to merge 1 commit into from

Conversation

@ribbons
Copy link
Contributor

@ribbons ribbons commented Mar 16, 2019

If makechrootpkg is called as non-root, the {SRC,SRCPKG,PKG,LOG}DEST, MAKEFLAGS and PACKAGER environment variables are lost in the call to check_root().

Add these to the passed keepenv list so that they are preserved instead.

If makechrootpkg is called as non-root, the {SRC,SRCPKG,PKG,LOG}DEST,
MAKEFLAGS and PACKAGER environment variables are lost in the call to
check_root().

Add these to the passed keepenv list so that they are preserved instead.
@Foxboron
Copy link
Member

@Foxboron Foxboron commented Mar 16, 2019

Very much the same issue as from 7b09525

LGTM.

@anthraxx
Copy link
Member

@anthraxx anthraxx commented Mar 22, 2019

LGTM, gonna send it over to the ML for giving people the chance to review over there and apply afterwards

@anthraxx
Copy link
Member

@anthraxx anthraxx commented Mar 25, 2019

@anthraxx anthraxx closed this Mar 25, 2019
@ribbons
Copy link
Contributor Author

@ribbons ribbons commented Mar 26, 2019

Many thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants