Fix unapplied ARM linux kernel patches in PKGBUILD #1749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKGBUILD is wrong for aarch64 linux kernel: The linux source code is downloaded as tgz and then patches are applied with git apply. It is not allowed to do so, and doing so lead to unapplied patches without throwing error. So lots of the patches are not applied. This patch use patch comand instead of git aply. Signed-off-by: Abdel Benamrouche <abdel@unxp.fr>
|
Why was this PR closed? |
|
No idea |
|
https://github.com/archlinuxarm/PKGBUILDs/blob/master/CONTRIBUTING.md
Let me also give you some context on why this PR is not needed: You should not be building the packages from the Git tree itself. Copy the contents of that package to a working folder (we literally tarball the working directories and ship them to the Plugbuild clients), and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKGBUILD is wrong for aarch64 linux kernel:
The linux source code is downloaded as tgz and then patches are applied
with git apply.
It is not allowed to do so, and doing so lead to unapplied patches
without throwing error. So lots of the patches are not applied.
This patch use patch comand instead of git aply.
Signed-off-by: Abdel Benamrouche abdel@unxp.fr