Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for official schemas in favor of our own #46

Open
tomkerkhove opened this Issue Nov 6, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@tomkerkhove
Copy link
Member

commented Nov 6, 2018

Last week Microsoft released a blog post with update on Azure Event Grid which announced an updated Azure SDK:

We have updated the .Net, Java, and Go SDKs to make consuming Azure Native Events even easier. Using the latest release of each, the SDK is now aware of all available event types being published by Azure. This means you can use Event Grid’s eventGridSubscriber to deserialize events directly for all known event types and start writing code against the content of the event rather than first having to deal with manually deserializing JSON into various different event type classes. Check the different SDKs for an easier experience managing your Event Grid resources and events.

After digging I found them here

Question is, should we still provide support for the Azure schemas over the official ones or should we use the official ones and make them compatible with our approach?

I would suggest to invest our time in the latter so that we can focus on other features as it will be hard to keep up.

@tomkerkhove tomkerkhove added the question label Nov 6, 2018

@tomkerkhove

This comment has been minimized.

Copy link
Member Author

commented Nov 15, 2018

@samneirinck

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2018

Don't think it makes sense to keep the ones in Arcus. What impact does it have?

@stijnmoreels

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

I'll have to look closer both in the blog post and the update to give you a good awnser. It seems logic to follow the Azure schema changes like @samneirinck said?

@tomkerkhove

This comment has been minimized.

Copy link
Member Author

commented Nov 15, 2018

That's what I would suggest as well. Briefly discusses with @SamVanhoutte this week and we would suggest that we make our approach compatible with the official approach.

Let me know what you think and I'll create a dedicated issue for this.

@SamVanhoutte

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2018

Agree - no reason to maintain our own. Will this introduce a breaking change, introducing this?

@tomkerkhove

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2018

We would have to look into it but I think so. Schemas can be marked as obsolete but it's going to be the core that has to be changed again to support them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.