Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline specific Azure Service Bus message handler templates by adding ...Message... to methods #194

Closed
stijnmoreels opened this issue Jun 22, 2021 · 0 comments · Fixed by #197
Closed

Streamline specific Azure Service Bus message handler templates by adding ...Message... to methods #194

stijnmoreels opened this issue Jun 22, 2021 · 0 comments · Fixed by #197
Labels
breaking-change All issues related to code breaking changes. enhancement New feature or request integration:service-bus All issues concerning integration with Azure Service Bus
Milestone
v1.0.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
The Azure Service Bus message handlers and fallback handlers have different methods regarding dead lettering, completing, and abandoning messages.

  • Message handler uses DeadLetterAsync, CompleteAsync, ect...
  • Fallback message handler uses DeadLetterMessageAsync, CompleteMessageAsync, ect...

Describe the solution you'd like
Use across all methods the ...Message... variant.
@stijnmoreels stijnmoreels added enhancement New feature or request integration:service-bus All issues concerning integration with Azure Service Bus breaking-change All issues related to code breaking changes. labels Jun 22, 2021
@stijnmoreels stijnmoreels added this to the v1.0.0 milestone Jun 22, 2021
@stijnmoreels stijnmoreels mentioned this issue Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change All issues related to code breaking changes. enhancement New feature or request integration:service-bus All issues concerning integration with Azure Service Bus
Projects
None yet
Milestone
v1.0.0
1 participant
@stijnmoreels